[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

Martin Storsjö martin
Sun May 9 18:40:42 CEST 2010

On Sun, 9 May 2010, Sebastian Vater wrote:

> Stefano Sabatini a ?crit :
> > On date Thursday 2010-05-06 23:23:20 +0200, Sebastian Vater encoded:
> >   
> >> Sebastian Vater a ?crit :
> >>     
> >>  /**
> >>   * Convert CMAP buffer (stored in extradata) to lavc palette format
> >>   */
> >> -int ff_cmap_read_palette(AVCodecContext *avctx, uint32_t *pal)
> >> +static int cmap_read_palette(AVCodecContext *avctx, uint32_t *pal)
> >>     
> >
> > This looks fine, but this change deserves a separate patch.
> >   
> Why? It's important to change this with HAM support, the old code
> doesn't really have any problems with it.

No, it is not important for this change. In this patch, you remove usage 
of ff_cmap_read_palette from libavformat/iff.c. You don't _need_ to change 
this now. The code will work just as well without changing this.

After this patch, when this function is only used within libavcodec/iff.c, 
you can do a separate patch where you make the function static and remove 
the ff_ prefix.

As repeated to you very many times already, do not change things in a 
patch unless you have to. The fewer lines changed in a patch, the better. 
Everything non-essential can be changed in a separate cosmetic patch.

// Martin

More information about the ffmpeg-devel mailing list