[FFmpeg-devel] [PATCH] RealMedia muxer: support audio codecs other than AC-3

[Francesco Lavra]

On Sat, 2010-05-08 at 19:14 +0200, Michael Niedermayer wrote:
> On Sat, May 08, 2010 at 09:15:30AM +0200, Francesco Lavra wrote:
> > [...]
> the list is not 1:1 but n:n
> one codec id can have multiple tags (ex: xvid/divx)
> and one codec tag can have multiple ids (ex mpeg1/mpeg2)
> you must check the values against the list

So the attached patches should be more correct. The changes to
libavformat/utils.c are in two separate patches: the first one adds the
two static functions find_avcodectag_from_id() and
find_avcodectag_from_tag(), and redefines ff_codec_get_tag() and
ff_codec_get_id() to use the new functions; the second patch adds the
actual changes to av_write_header().

> also dont forget to test your code against the regression tests & fate

Since one regression test (jpegls) broke with this change,
01_jpegls.patch contains the necessary addition to riff.c to make the
test pass.
Also, I can't run fate since the fate suite folder in mplayerhq.hu (the
entire samples folder, actually) is currently unavailable.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_jpegls.patch
Type: text/x-patch
Size: 725 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100509/6ff7d364/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_utils.patch
Type: text/x-patch
Size: 1789 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100509/6ff7d364/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03_utils.patch
Type: text/x-patch
Size: 2695 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100509/6ff7d364/attachment-0002.bin>