[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

[Sebastian Vater]

Michael Niedermayer a ?crit :
> On Wed, May 05, 2010 at 07:01:48PM +0200, Sebastian Vater wrote:
>   
>> Michael Niedermayer a ?crit :
>>     
>>> On Wed, May 05, 2010 at 05:28:07PM +0200, Sebastian Vater wrote:
>>>   
>>>
>>>       
>>>> @@ -152,9 +157,15 @@ static int iff_read_header(AVFormatContext *s,
>>>>              st->codec->channels = (get_be32(pb) < 6) ? 1 : 2;
>>>>              break;
>>>>  
>>>> +        case ID_CAMG:
>>>> +            if (data_size < 4)
>>>> +                return AVERROR_INVALIDDATA;
>>>> +            screenmode                = get_be32(pb);
>>>> +            break;
>>>>     
>>>>         
>>> can this value change from frame to frame or is it constant throghout a movie?
>>> if it can change then it must be stored in AVPacket.data
>>>   
>>>       
>> Screenmode is constant, of course. Have you ever seen any video format
>> which opens a new screen (i.e. changes video mode)?
>>     
>
> yes i have :)
>   

Really? Which one is this, I'm just curious about this!

But I was looking again on this if that's true for IFF-ANIM...well IFF
ANIM files have just one FORM...ILBM chunk, and therefore also just one
BMHD chunk (where the screenmode is defined), so it can't be changed
afterwards...

However, I've attached a small bug fix for my HAM support patch which
identified some files wrongly as having transparent color (old code was
just checking if transparent color != 0 but that's wrong, the mask
itself has to be checked).

Apart from this, it's pretty the same, hope this patch is ok, so we can
finally add it to git/svn to have full HAM support ;)

-- 

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-ham-support.patch
Type: text/x-patch
Size: 20965 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100508/95c5f2f8/attachment.bin>