[FFmpeg-devel] [PATCH] HAM6/HAM8 support for IFF demuxer/decoder

Ronald S. Bultje rsbultje
Thu May 6 19:09:25 CEST 2010


On Thu, May 6, 2010 at 1:05 PM, Sebastian Vater
<cdgs.basty at googlemail.com> wrote:
> An extradata pointing to NULL is perfectly valid for the old decoder if
> either having number of bitplanes > 8 or with image having no CMAP chunk
> (grayscale image).

That's fine, but then just put the whole extradata reading under an if
(extradata) { ... }. Now you do it per-call, which is inefficient in
both code size as well as performance.

> The question remains though, if it still makes sense to use bytestream.h
> API when the NULL ptr checks are always required...

I don't think that's the case...


More information about the ffmpeg-devel mailing list