[FFmpeg-devel] [PATCH] Chromium MKV patches

[Michael Niedermayer]

On Wed, May 05, 2010 at 03:51:47PM -0400, David Conrad wrote:
> On May 5, 2010, at 7:17 AM, Michael Niedermayer wrote:
> 
> > On Wed, May 05, 2010 at 05:18:20AM -0400, David Conrad wrote:
> >> Hi,
> >> 
> >> Here are the useful patches from chromium for the mkv demuxer. 1 doesn't fix any actual issues that I'm aware of, but might make it easier to spot any if they exist.
> > 
> >> 
> >> Another change made was ensuring sample_rate was nonzero, but AFAIK a zero sample_rate meant unknown and applications should handle that instead of the demuxer inventing a rate?
> > 
> > i was unaware that matroska allowed a undefined sample_rate, thats broken
> > design for a container that normally stores the sample_rate
> > the solution may be to set needs_parsing to headers only if its not a
> > higher value alraedy
> > having the problematic mkv file woulf of course help to see what exactly
> > is the problem
> 
> It's not that it allows undefined sample_rate, but rather that it's possible for a file to have 0 written for sample_rate, which is probably true of most containers.
> 
> need_parsing is already set to AVSTREAM_PARSE_HEADERS for everything except aac.
> 
> I'll ask for the file, but google's lawyers are apparently deathly afraid of sharing even public-domain videos.

then ask them for the filename google it and download ;)

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The educated differ from the uneducated as much as the living from the
dead. -- Aristotle 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100506/27486f5d/attachment.pgp>