[FFmpeg-devel] [PATCH] Fix non-rounding up to next 16-bit aligned bug in IFF decoder

[Michael Niedermayer]

On Tue, May 04, 2010 at 10:11:30PM +0200, Sebastian Vater wrote:
> Sebastian Vater a ?crit :
> > I have fixed the wrong IFF decoding issue in the IFF decoder.
> >
> > The reason is that the IFF docs say that each line in the BODY chunk has
> > it's width rounded up to next 16-bit boundary, such that each new line
> > begins on a word boundary (address divisible by 2).
> >
> > Please review and apply.
> >
> > I will do the heavy optimization stuff now based on this.
> >   
> 
> So, since there were changes in git/svn because unsigned => signed, my
> earlier patches regarding this won't work anymore.
> 
> So, here's an updated version.
> 
> -- 
> 
> Best regards,
>                    :-) Basty/CDGS (-:
> 

>  iff.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> c8bc2e7faefd09893e86206a4077c1cf3ca927d1  iff-decoder-fix.patch

i think this patch is ok but iam not sure if the code before and afterwards
is ok.
have you tested files with odd width? i mean with ffmpeg and the official
decoder?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

In fact, the RIAA has been known to suggest that students drop out
of college or go to community college in order to be able to afford
settlements. -- The RIAA
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100505/4dc1fba3/attachment.pgp>