[FFmpeg-devel] [PATCH] Add IFF metadata handling

[Sebastian Vater]

Vladimir Pantelic a ?crit :
> Sebastian Vater wrote:
>> Anton Khirnov a ?crit :
>>>  On Fri, Apr 30, 2010 at 02:14:03PM +0200, Sebastian Vater wrote:
>>>
>>>>  +
>>>>  +        case ID_AUTH:
>>>>  +            buf = get_metadata(pb, data_size);
>>>>  +            if (!buf)
>>>>  +                break;
>>>>  +            av_metadata_set2(&s->metadata, "author", buf,
>>>> AV_METADATA_DONT_STRDUP_VAL);
>>>>  +            break;
>>>>
>>>  Correct generic tagname is 'artist', see list in avformat.h. (or add a
>>>  conv table)
>>>
>>
>> Fixed!
>
> why not roll these 3 lines into get_metadata() as well?

Oh yes, you're right. Fixed!

Best regards,
                   :-) Basty/CDGS (-:

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iff-metadata.patch
Type: text/x-diff
Size: 2299 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100503/04787ead/attachment.patch>