[FFmpeg-devel] [PATCH] avcodec_copy_context()

[Michael Niedermayer]

On Wed, Mar 31, 2010 at 11:19:18AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Wed, Mar 31, 2010 at 10:53 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Wed, Mar 31, 2010 at 10:11:11AM -0400, Ronald S. Bultje wrote:
> >> On Wed, Mar 31, 2010 at 9:59 AM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> >> > Hi Michael,
> >> >
> >> > On Wed, Mar 31, 2010 at 6:00 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> >> On Tue, Mar 30, 2010 at 02:23:03PM -0400, Ronald S. Bultje wrote:
> >> >>> + * @param dest target codec context, should be allocated with
> >> >>> + * ? ? ? ? ? ? #avcodec_alloc_context(), but otherwise uninitialized
> >> >>
> >> >> this should be checked if(->codec) or so maybe
> >> >
> >> > Coding error, so should be assert(), will add.
> >
> > avcodec* is public api and public api should not call abort() for invalid
> > user arguments imho
> 
> You're right, now that I think about it. AVERROR(EFAULT) OK then?

EINVAL id say

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100331/5d0223af/attachment.pgp>