[FFmpeg-devel] Fix FFM-based audio streaming from FFmpeg to FFserver
Tue Mar 30 01:35:50 CEST 2010
On Sun, Mar 28, 2010 at 09:55:13PM -0400, Ronald S. Bultje wrote:
> On Thu, Mar 25, 2010 at 6:28 PM, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > On Tue, Mar 16, 2010 at 6:02 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> a clone function is usefull, yet another local hack for a special case
> >> is unmaintainable. It will break in no time, especially without regression
> >> tests. And with reg tests i know i will curse the continous need to
> >> fix it after every second addition to AVCodecContext.
> >> Sorry but i think any design for which a addition to AVCodecContext in
> >> avcodec.h requires one to go over the source and to update all the local
> >> hacks that copy it (for rt*p, for ffserver, ...) is not practical
> > OK, so attached adds a primitive copying function that appears to work
> > and I think is correct for most pointer-related resources in
> > AVCodecContext.
> Ping. Should I send a patch for the avcodec_copy_context() function
> separately to make this easier to review?
i think a split might help, yes
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
There will always be a question for which you do not know the correct awnser.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: Digital signature
More information about the ffmpeg-devel