[FFmpeg-devel] [PATCH] Fix encoding when delay > number of frames

[Baptiste Coudurier]

On 03/29/2010 11:22 AM, Reimar D?ffinger wrote:
> On Mon, Mar 29, 2010 at 11:06:26AM -0700, Baptiste Coudurier wrote:
>>> Also I think that our x264 encoder still does not use x264_encoder_delayed_frames,
>>> sure that isn't the real issue maybe?
>>
>> That is the issue, but I'm not sure how it would be useful here.
>> Problem is:
>> All frames are given to the encoder in the main loop, no frames are
>> output in the main because delay is too big.
>> The flush loop outputs no frame because of the<= 0 return value check.
>
> The FFmpeg API is that way that an encoder should never return 0 if there
> are still delayed frames.
 >
> So the libx264 module should loop itself until either it has some new data
> or there are no more delayed frames.

Right, patch attached.

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: x264_encoding_delay.patch
Type: text/x-diff
Size: 675 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100329/33103f0f/attachment.patch>