[FFmpeg-devel] [PATCH] wmaprodec rewrite interleaving

[Michael Niedermayer]

On Sat, Mar 27, 2010 at 12:17:53PM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> the interleaving code right now is plain ugly, this is an attempt to
> make it slightly less ugly. But honestly someone should write a DSP
> function for this (and that's not me), because other decoders (e.g.
> atrac1) do similar silly stuff and I'm sure that can be optimized.
> 
> Ronald

>  wmaprodec.c |    9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> deba7253ee66b362f937518a273052ae28de51d8  simplify_wmaprodec_interleaving_code.patch
> Index: ffmpeg-svn/libavcodec/wmaprodec.c
> ===================================================================
> --- ffmpeg-svn.orig/libavcodec/wmaprodec.c	2010-03-27 10:48:32.000000000 -0400
> +++ ffmpeg-svn/libavcodec/wmaprodec.c	2010-03-27 12:06:42.000000000 -0400
> @@ -1343,14 +1343,11 @@
>  
>      /** interleave samples and write them to the output buffer */
>      for (i = 0; i < s->num_channels; i++) {
> -        float* ptr;
> +        float *ptr  = s->samples + i, *iptr = s->channel[i].out,
> +              *iend = iptr + s->samples_per_frame;

puting all that on a single line is not an improvment


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100327/b9480589/attachment.pgp>