[FFmpeg-devel] [PATCH] libavformat: Don't return errors if select is interrupted

Martin Storsjö martin
Fri Mar 26 08:43:13 CET 2010


On Fri, 26 Mar 2010, Michael Niedermayer wrote:

> On Fri, Mar 05, 2010 at 11:00:32AM +0200, Martin Storsj? wrote:
> [...]
> > diff --git a/libavformat/tcp.c b/libavformat/tcp.c
> > index a8cf80f..20e8acb 100644
> > --- a/libavformat/tcp.c
> > +++ b/libavformat/tcp.c
> > @@ -149,6 +149,8 @@ static int tcp_read(URLContext *h, uint8_t *buf, int size)
> >                      return AVERROR(ff_neterrno());
> >              } else return len;
> >          } else if (ret < 0) {
> > +            if (ff_neterrno() == FF_NETERROR(EINTR))
> > +                continue;
> >              return -1;
> >          }
> >      }
> 
> should not many of these also check url_interrupt_cb() before continue?

Yes, but that's done as the first thing in the loop, after the continue, 
so it's not necessary to do it here.

// Martin



More information about the ffmpeg-devel mailing list