[FFmpeg-devel] [patch]MMS protocol over TCP

[zhentan feng]

Hi

On Thu, Mar 25, 2010 at 5:34 AM, Ronald S. Bultje <rsbultje at gmail.com>wrote:

> Hi,
>
> On Wed, Mar 24, 2010 at 12:58 PM, zhentan feng <spyfeng at gmail.com> wrote:
> > modified the code according to all reviews.
> > see the patch version 2.
>
> > Index: libavformat/Makefile
> [..]
> > +OBJS-$(CONFIG_MMST_PROTOCOL)             += mmst.o
>
> Add asf.o
>


added it.


> +#define LOCAL_ADDRESS 0xc0a80081    // server doesn't care about it.
>
> 192.168.0.something - Probably should add a FIXME here that we should
> actually give our IP, plus at least mention what IP it stands for.
>
> fixed.


> > +typedef enum {
> > +    CS_PKT_INITIAL= 0x01,
> > +    CS_PKT_PROTOCOL_SELECT= 0x02,
> > +    CS_PKT_MEDIA_FILE_REQUEST= 0x05,
> > +    CS_PKT_START_FROM_PKT_ID= 0x07,
> > +    CS_PKT_STREAM_PAUSE= 0x09,
> > +    CS_PKT_STREAM_CLOSE= 0x0d,
> > +    CS_PKT_MEDIA_HEADER_REQUEST= 0x15,
> > +    CS_PKT_TIMING_DATA_REQUEST= 0x18,
> > +    CS_PKT_USER_PASSWORD= 0x1a,
> > +    CS_PKT_KEEPALIVE= 0x1b,
> > +    CS_PKT_STREAM_ID_REQUEST= 0x33,
> > +} MMSCSPacketType;
> [..]
> > +} MMSSCPacketType;
>
> Please vertically align these, i.e.:
>    CS_PKT_BLA       = 0x0,
>    CS_PKT_SOMETHING = 0x1,
> [etc]
>
>
fixed.


> > +static void start_command_packet(MMSContext *mms, MMSCSPacketType
> packet_type)
> [..]
> > +    put_le64(context, 0); // timestmamp
>
> timestamp
>
> Rest is OK, great work! If nobody else objects, I'll apply your next
> patch in approx. 3 days.
>
>
here is the new patch according to the reviews.
zhentan
-- 
Best wishes~
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mmst_3.patch
Type: application/octet-stream
Size: 25993 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100325/948fd5b4/attachment.obj>