[FFmpeg-devel] theora depayloader

Josh Allmann joshua.allmann
Mon Mar 22 16:45:06 CET 2010


Updated against latest trunk -- there was a changelog conflict, now resolved.

On 22 March 2010 11:16, Martin Storsj? <martin at martin.st> wrote:
> On Mon, 22 Mar 2010, Josh Allmann wrote:
>
>> It is now:
>> + ? ?extradata_alloc = length + length/255 + 3 + FF_INPUT_BUFFER_PADDING_SIZE;
>
> Ok, good. Update the comment above this too (e.g. "length/255 + 2 for
> xiphlacing").
>
>> Got the rest of them, hopefully.
>
>> + ? ? ? ? ? ? ? ?av_log(codec, AV_LOG_ERROR,
>> + ? ? ? ? ? ? ? ? ? ? ? ?"Out of memory while decoding SDP configuration.\n");
>
> The quoted text is off by one. :-)
>
> With these changes, I'm ok with the patch too. If you send a new one
> addresing Ronald's comments, I'll apply it.

Apply away :)

Josh
-------------- next part --------------
A non-text attachment was scrubbed...
Name: theora_depayloader.diff
Type: text/x-patch
Size: 16015 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100322/ebe659a7/attachment.bin>



More information about the ffmpeg-devel mailing list