[FFmpeg-devel] [PATCH] hardcoding for pcm alaw/ulaw tables

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Mar 21, 2010 at 10:44:32PM +0100, Reimar D?ffinger wrote:
>> On Sun, Mar 21, 2010 at 10:13:54PM +0100, Michael Niedermayer wrote:
>> > The point iam trying to make, and it seems quite unsccessfull is that
>> > the generators as thay are are just lots of red tape that is unreadable,
>> > and undocumented
>> 
>> Ok, but you must understand it doesn't feel like that to me (with
>> the exception of the av_cold/CONFIG_... defines) since I wrote the
>> code, and while I do copy existing code with this infrastructure it
>> usually takes me only minutes to get a working version.
>
> cant we get rid of av_cold by just not using av_cold ?

What's the problem with av_cold anyway?  It's defined in
libavutil/attributes.h, why not simply #include that?

>> > what is needed IMO is
>> > 1. the code must be readable by just looking at it without looking up
>> >    everything and just accepting that some statements are there and it
>> >    wont compile where they not.
>> 
>> While in principle I agree, due to having to support cross-compiling those
>> table generators are tricky, and I have some doubts it is possible to make
>> them quite as simple as you (and to a degree I) want them to be.
>
> do we really need cross compileation support for them ?
> i mean something like
> 1. configure + make for tables
> 2. configure + make for cross compile

Very bad idea.

-- 
M?ns Rullg?rd
mans at mansr.com