[FFmpeg-devel] [RFC] move some *_tablegen.c defines to Makefile

[Måns Rullgård]

Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> Hello,
> just a possible suggestion to avoid some "magic" in the table generators.
> I freely admit there maybe are already too many "hacks" related to this
> feature in the Makefile, but currently Michael is complaining louder than
> M?ns :-)
>
> Reimar
>
> Index: libavcodec/Makefile
> ===================================================================
> --- libavcodec/Makefile	(revision 22622)
> +++ libavcodec/Makefile	(working copy)
> @@ -633,7 +633,7 @@
>  endif
>  
>  $(SUBDIR)%_tablegen$(HOSTEXESUF): $(SUBDIR)%_tablegen.c $(SUBDIR)tableprint.c
> -	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTLIBS)
> +	$(HOSTCC) -Dav_cold= -DCONFIG_HARDCODED_TABLES=0 $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTLIBS)

I don't like this.

-- 
M?ns Rullg?rd
mans at mansr.com