[FFmpeg-devel] [RFC] ffplay direct rendering with libavfilter

[Michael Niedermayer]

On Sun, Mar 21, 2010 at 12:14:11PM +0100, Vitor Sessak wrote:
> Bobby Bingham wrote:
>> I haven't dealt much with the codec API yet, so I wouldn't be surprised
>> if I'm doing something wrong. So I'm posting this for feedback.  No
>> slices support yet. The EMU_EDGE handling is ugly - is there a way to
>> get the value of EDGE_WIDTH from outside of libavcodec?
>> I've tested it with videos encoded with a few different codecs and it
>> seems to work.
>
> Nice! \o/
>
> Just one thing, what about of this code (at ffplay.c:1418):
>
>>         //FIXME use direct rendering
>>         av_picture_copy(&pict, &pict_src,
>>                         vp->pix_fmt, vp->width, vp->height);
>
> It should be removed also, no?

yes but this copy was there before (hidden in a call to swscale)
also getting rid of this is related to video out (SDL currently)
buffer management.
Ideally the VO should be able to provide buffers to the filter chain
and the filter chain should then be able to reorder them, draw into
them and return them.
iam not even sure if SDL can handle arbitrary number of buffers ...
either way i think this is low priority compared to getting ffmpeg.c
libavfilter support.
But if someone wants to work on this it should be kept as SDL indepandant
as possible so we can add some other (not so badly sucking) video out
support.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100321/745a83b9/attachment.pgp>