[FFmpeg-devel] [PATCH] Redefine AVERROR_INVALIDDATA as a specific FFmpeg error code at the next lavu major bump

[Stefano Sabatini]

On date Thursday 2010-03-18 03:38:13 +0100, Michael Niedermayer encoded:
> On Thu, Mar 18, 2010 at 01:42:03AM +0100, Stefano Sabatini wrote:
> > On date Wednesday 2010-03-17 03:44:26 +0100, Michael Niedermayer encoded:
> > > On Sat, Mar 13, 2010 at 09:49:43PM +0100, Stefano Sabatini wrote:
> > > > $subj.
> > > > -- 
> > > > FFmpeg = Free and Faithless Monstrous Patchable Erroneous Gigant
> > > 
> > > >  error.h |    3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > a9d5b2f485a823f9e1465a01ae4262e8a1f36e14  0006-Change-the-definition-of-AVERROR_INVALIDDATA-at-the-.patch
> > > > >From fbad6c9da276ce8e3cb091763ab2a70620c38d31 Mon Sep 17 00:00:00 2001
> > > > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > > > Date: Sat, 13 Mar 2010 21:25:45 +0100
> > > > Subject: [PATCH 6/8] Change the definition of AVERROR_INVALIDDATA at the next libavutil
> > > >  major bump, using an FFmpeg specific error code rather than EINVAL,
> > > >  which has a quite different semantics.
> > > > 
> > > > ---
> > > >  libavutil/error.h |    3 ++-
> > > >  1 files changed, 2 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/libavutil/error.h b/libavutil/error.h
> > > > index 7be1b4c..cb07be8 100644
> > > > --- a/libavutil/error.h
> > > > +++ b/libavutil/error.h
> > > > @@ -46,14 +46,15 @@
> > > >  #define AVERROR_NOENT       AVERROR(ENOENT)  /**< No such file or directory. */
> > > >  #define AVERROR_NUMEXPECTED AVERROR(EDOM)    /**< Number syntax expected in filename. */
> > > >  #define AVERROR_EOF         AVERROR(EPIPE)   /**< End of file. */
> > > > +#define AVERROR_INVALIDDATA AVERROR(EINVAL)  /**< invalid data found */
> > > >  #endif
> > > >  
> > > > -#define AVERROR_INVALIDDATA AVERROR(EINVAL)  /**< invalid data found */
> > > >  #define AVERROR_NOFMT       AVERROR(EILSEQ)  /**< unknown format */
> > > >  #define AVERROR_NOTSUPP     AVERROR(ENOSYS)  /**< Operation not supported. */
> > > >  #define AVERROR_PATCHWELCOME    (-MKTAG('P','A','W','E')) /**< Not yet implemented in FFmpeg. Patches welcome. */
> > > >  
> > > >  #if LIBAVUTIL_VERSION_MAJOR > 50
> > > > +#define AVERROR_INVALIDDATA     (-MKTAG('I','N','D','A')) /**< invalid data found */
> > > 
> > > id make that IVDT
> > 
> > If you prefer it than I won't object (but "INvalid DAta" seemed just
> > more consistent with "NUm EXpected" and "PAtch WElcome").
> 
> i really dont care what its named, this is pure bikeshed, pick what
> you prefer, i dont even know if i prefer my own suggestion ;)
> 
> 
> > 
> > > and what does "invalid data found" mean?
> > > thats a far too terse description
> > 
> > >From cmdutils.c:print_error():
> >         fprintf(stderr, "%s: Error while parsing header\n", filename);
> > 
> > Which is not quite correct. In general this seems is used when the
> > parameters/data contained in a incoming stream cannot be validated,
> > *or* it is impossible to read / parse the incoming stream.
> > 
> > My try at describing it:
> > "(Invalid|illegal) data found when (processing|parsing) input (stream?)"
> 
> sounds good

Updated.
-- 
FFmpeg = Fostering & Foolish Moronic Peaceless Eretic Gorilla