[FFmpeg-devel] [PATCH] RTMPE support

[Howard Chu]

Carl Eugen Hoyos wrote:
> Howard Chu<hyc<at>  highlandsun.com>  writes:
>
>> Here's a librtmp wrapper for libavformat. These diffs are needed as well:
>
> The preferred method to post such a change is:
> svn add libavformat/rtmp2.c
> svn di libavformat>patch.diff
>
> I don't think the patch should disable the current code (did you open
> bug-reports for the cases where it does not work?)

Since the new code is a superset of the existing code, there doesn't seem to 
be any reason to keep both. Nor would it be helpful to users, since e.g. RTMP 
servers can deploy SWFverification on any stream, and keeping the existing 
rtmp code in tandem with the new code would leave a feature mismatch - regular 
rtmp URLs that require verification would fail for no apparent reason.

> and your new file contains
> tabs that cannot be committed to svn (please consider running tools/patcheck).

Done.

> Before sending a new patch, the usefulness of adding a new external dependency
> should probably be discussed.

Discussion is all well and good, but at the end of the day the original 
question remains unanswered - do you want the new features or not. Now, or 
later. This patch provides everything, now.

-- 
   -- Howard Chu
   CTO, Symas Corp.           http://www.symas.com
   Director, Highland Sun     http://highlandsun.com/hyc/
   Chief Architect, OpenLDAP  http://www.openldap.org/project/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch.diff
Type: text/x-patch
Size: 10051 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100318/3ef1ef00/attachment.bin>