[FFmpeg-devel] [PATCH] Allow window caption to be set for ffplay

Stefano Sabatini stefano.sabatini-lala
Thu Mar 18 00:38:14 CET 2010


On date Wednesday 2010-03-17 19:38:05 +0100, Michael Niedermayer encoded:
> On Wed, Mar 17, 2010 at 05:03:34PM +0100, Robert Kr?ger wrote:
> > 
> > On 17.03.2010, at 15:55, Michael Niedermayer wrote:
> > 
> > > On Wed, Mar 17, 2010 at 08:01:05AM +0100, Robert Kr?ger wrote:
> > >> 
> > >> On 16.03.2010, at 22:43, M?ns Rullg?rd wrote:
> > >> 
> > >>> Michael Niedermayer <michaelni at gmx.at> writes:
> > >>> 
> > >>>> On Tue, Mar 16, 2010 at 11:35:10AM +0100, Robert Kr?ger wrote:
> > >>>>> 
> > >> 
> > >> +static void opt_window_title(const char *arg)
> > >> +{
> > >> +    window_title = arg;
> > >> +}
> > > 
> > > missing strdup but its code duplication, OPT_STRING does this simpler
> > > 
> > 
> > new patch attached
> > 
> 
> >  doc/ffplay-doc.texi |    2 ++
> >  ffplay.c            |    6 +++++-
> >  2 files changed, 7 insertions(+), 1 deletion(-)
> > 74162ec1ceab6db9541bcfac7d74d08f9450c773  ffplay_window_title.patch
> 
> ok

Applied, thanks for the contribution.
-- 
FFmpeg = Fundamentalist and Free Mythic Powerful Elected Guru



More information about the ffmpeg-devel mailing list