[FFmpeg-devel] [PATCH] fix the SAMPLE_FMT_NONE case in ffmdec.c

[Måns Rullgård]

"Ronald S. Bultje" <rsbultje at gmail.com> writes:

> Hi,
>
> 2010/3/16 M?ns Rullg?rd <mans at mansr.com>:
>> My mistake. ?I forgot the exact-width types are special. ?My original
>> statement is still correct though: conversion to a signed type of a
>> value outside the range of that type is implementation-defined, even
>> for fixed-width types.
>
> So what is the consensus? int16_t cast or sign_extend()? I want to
> apply this patch, this is a bug that should be fixed.

Cast is fine with me if this is the only place it's needed.  Otherwise
a companion function to get_le16() reading a signed value would be the
preferable solution.

-- 
M?ns Rullg?rd
mans at mansr.com