[FFmpeg-devel] [PATCH] Call rdft by function pointer
Måns Rullgård
mans
Tue Mar 16 12:40:24 CET 2010
Alex Converse <alex.converse at gmail.com> writes:
> 2010/3/14 M?ns Rullg?rd <mans at mansr.com>:
>> Alex Converse <alex.converse at gmail.com> writes:
>>
>>> Call the RDFT by a function pointer like other FFT related transforms.
>>> This makes instruction set optimized versions possible.
>
> void ff_rdft_calc(RDFTContext *s, FFTSample *data)
> {
> - ff_rdft_calc_c(s, data);
> + s->rdft_calc(s, data);
> }
To avoid double function call overhead, perhaps that function should
be moved to fft.h as an inline.
Side note: gcc sometimes fails to optimise a tail call through a
function pointer into a plain jump.
--
M?ns Rullg?rd
mans at mansr.com
More information about the ffmpeg-devel
mailing list