[FFmpeg-devel] [PATCH] Move H264 dsputil functions into their own struct

[Michael Niedermayer]

On Tue, Mar 16, 2010 at 12:49:39AM +0000, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > On Tue, Mar 16, 2010 at 12:17:43AM +0000, M?ns Rullg?rd wrote:
> >> Michael Niedermayer <michaelni at gmx.at> writes:
> >> 
> >> > On Sun, Mar 14, 2010 at 05:17:32PM +0000, Mans Rullgard wrote:
> >> >> This moves the H264-specific functions from DSPContext to the new
> >> >> H264DSPContext.  The code is made conditional on CONFIG_H264DSP
> >> >> which is set by the codecs requiring it.
> >> >> 
> >> >> The qpel and chroma MC functions are not moved as these are used by
> >> >> non-h264 code.
> >> > [...]
> >> >
> >> >> --- /dev/null
> >> >> +++ b/libavcodec/h264dsp.c
> >> >
> >> > dont forget svn cp
> >> 
> >> So which files should be cp'd?  Even the ones moving only a few lines
> >> out of thousands?
> >
> > one moving 10 lines out of 1000 doesnt need to be cped
> > also if the lines are stuff like just prototypes or comments then i care less
> 
> So in this specific case?  Just dsputil.c -> h264dsp.c or the .h files
> as well?

this is a tough question, the header is quite borderline
but i think i would slightly lean toward copyint it  too
for H264DSPContexts history mostly

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100316/5b1c2149/attachment.pgp>