[FFmpeg-devel] [PATCH] SSE RDFT

[Michael Niedermayer]

On Sun, Mar 14, 2010 at 10:51:06PM +0000, M?ns Rullg?rd wrote:
> Alex Converse <alex.converse at gmail.com> writes:
> 
> > 2010/3/14 M?ns Rullg?rd <mans at mansr.com>:
> >> Alex Converse <alex.converse at gmail.com> writes:
> >>
> >>> I'm sure I've made some embarrassingly amateurish mistakes here.
> >>> Feedback is more than welcome.
> >>
> >> The first one is doing it in inline asm. ?New asm should preferably
> >> use yasm.
> >>
> >
> > Dammed if you do, dammed if you don't. Last time did an SSE function I
> > used yasm and there were complaints that people preferred inline.
> 
> Michael is the only person insisting on inline.  Everybody else agress
> that yasm is far more reliable.

reliability is one part, portability, flexibility,maintainability and speed
another, and you dont know everybodies oppinion
thats besides that iam x86 maintainer and the author of quite alot of the
x86 code thus i claim that i do know what i talk about. I was the one keeping
the inline asm working over the years and thus if i say its little work
really you can belive me it is.


yasm vs. inline is for the most part bikeshed, but there are cases where one
wants to keep parts of the code in C for maintainability or integrate the
code into C code avoiding call overhead. For these cases inline is required
And we dont always know ahead of time where call overhead will matter.

And there are also cases where there is existing code in yasm, for these
it makes sense to keep the code in yasm as its less work and allows easy
merging back and forth of changes.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I hate to see young programmers poisoned by the kind of thinking
Ulrich Drepper puts forward since it is simply too narrow -- Roman Shaposhnik
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100315/a077cbcc/attachment.pgp>