[FFmpeg-devel] [PATCH] Publicly declare av_match_ext()

Stefano Sabatini stefano.sabatini-lala
Fri Mar 12 00:36:27 CET 2010


On date Wednesday 2010-03-10 14:15:48 -0500, Ronald S. Bultje encoded:
> Hi,
> 
> On Wed, Mar 10, 2010 at 2:10 PM, Stefano Sabatini
> <stefano.sabatini-lala at poste.it> wrote:
> > On date Tuesday 2010-03-09 00:58:16 +0100, Stefano Sabatini encoded:
> >> Hi, as in subject, fixes a warning in ffserver.c.
> >
> > Ping.
> 
> ffserver.c has several such problems.
> 
> Do we want FFmpeg (lavf/c/u) to contain such functionality? It seems
> out-of-place to me. How about we simply add a (static) copy of the
> match_ext() function in ffserver.c, with possibly a comment etc.?
> 
> I know, code duplication is bad, it's just a thought. Feel free to reject.

I don't have a strong idea and I recognize av_match_ext() is a little
overspecialized to be used in a lib. Nonetheless I'd slightly prefer
to make it public, at least it would avoid code duplication.

Regards.
-- 
FFmpeg = Faithless Fiendish Moronic Problematic Entertaining God



More information about the ffmpeg-devel mailing list