[FFmpeg-devel] [PATCH] RFC: separate DWT code from snow

Måns Rullgård mans
Thu Mar 11 13:11:04 CET 2010


Michael Niedermayer <michaelni at gmx.at> writes:

> On Thu, Mar 11, 2010 at 03:16:38AM +0000, Mans Rullgard wrote:
> [...]
>> +#define slice_buffer_get_line(slice_buf, line_num) ((slice_buf)->line[line_num] ? (slice_buf)->line[line_num] : slice_buffer_load_line((slice_buf), (line_num)))
>> +//#define slice_buffer_get_line(slice_buf, line_num) (slice_buffer_load_line((slice_buf), (line_num)))
>> +
>> +void slice_buffer_init(slice_buffer * buf, int line_count, int max_allocated_lines, int line_width, IDWTELEM * base_buffer);
>> +void slice_buffer_release(slice_buffer * buf, int line);
>> +void slice_buffer_flush(slice_buffer * buf);
>> +void slice_buffer_destroy(slice_buffer * buf);
>> +IDWTELEM * slice_buffer_load_line(slice_buffer * buf, int line);
>
> these should be documented, ideally by their author ...

Yes, and I'll gladly leave that to the author.  What I'm asking is
if this split is OK, and if it's being done in the right place.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list