[FFmpeg-devel] [PATCH] Sync the NTP timestamps for RTP streams

[Luca Abeni]

On 10/03/10 21:52, Martin Storsj? wrote:
[...]
>>>> I am not sure if we want a public av_ntp_time() function. I'd be
>>>> inclined to go for a private ff_ntp_time(), but I'd like to hear
>>>> other people's opinions too.
>>>
>>> I think it could have some uses outside, yet it's quite simple so either
>>> way won't cause much harm.
>>
>> Well, the one use outside would be for setting a sane value for the
>> coordinated start time. But I'm ok with keeping it private for now, since
>> it's simple to reimplement outside if needed anyway.
>
> Updated patch series, made the ntp_time a libavformat internal function
> with an ff prefix, still using metadata for passing the data. Added an
> RTP: prefix to the metadata key.

Patch 1 is ok and can be committed;
if using metadata for the NTP start time is acceptable, then Patch 2 is 
ok too (and patch 3 too). Otherwise, AVOptions should be used (as 
suggested by Michael).


			Thanks,
				Luca