[FFmpeg-devel] [PATCH] HE-AAC v1 try 5

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sun, Mar 07, 2010 at 07:06:36PM -0800, Jason Garrett-Glaser wrote:
>> 2010/3/6 M?ns Rullg?rd <mans at mansr.com>:
>> > Michael Niedermayer <michaelni at gmx.at> writes:
>> >
>> >> One thing though must be resolved first, and that are the variable names
>> >> they are all 1:1 copied from the spec and i do not know if we can legally
>> >> include this in a *GPL program in terms of copyright.
>> >
>> > Of course we can. ?Copyright doesn't extend that far.
>> 
>> And if we couldn't, then we better start rewriting the H.264 decoder.
>
> our h264 decoder likely uses the same terms/variables as the spec
> to refer to things. the code here though uses the same variable names
> as sample C code in the spec.

No difference from a copyright point of view.

>> This is a stupid concern.
>
> then id like to know why did we had to rewrite an idct that was taken from
> reference code?
> Whats the difference that now its supposed to be ok but previously in a
> similar case it was not?

Copying of entire non-trivial functions falls squarely within the
realm of copyright.  Using the same names in otherwise original code
does not.

-- 
M?ns Rullg?rd
mans at mansr.com