[FFmpeg-devel] libavcodec/pthread.c:138: error: no previous prototype for 'avcodec_thread_execute2'

[Andreas Öman]

Benoit Fouet wrote:
> On Mon, 08 Mar 2010 13:58:49 +0100 Andreas ?man wrote:
>> Georgi Chorbadzhiyski wrote:
>>> Around 03/08/10 12:43, Benoit Fouet scribbled:
>>>> On Mon, 08 Mar 2010 12:28:37 +0200 Georgi Chorbadzhiyski wrote:
>>>>> gf at gf:~/ffmpeg$ make
>>>>> CC      libavcodec/pthread.o
>>>>> libavcodec/pthread.c:138: error: no previous prototype for 'avcodec_thread_execute2'
>>>>> make: *** [libavcodec/pthread.o] Error 1
>>>>>
>>>>> This fixes it but I don't think this is the correct fix. It should not give error
>>>>> here.
>>>> missing prototypes now results in an error.
>>> I've missed this. This is a good change.
>> Fixed, and for w32thread.c as well.
> 
> Your fix is not in line with what exists e.g. for avcodec_thread_execute
> I don't know which solution we should aim at, but now we're somewhere
> in between, and IMHO, that needs to be fixed: either make
> avcodec_thread_execute2 part of the API, or remove the other ones from
> the API.
> 

Hm, I'm not sure what you are aiming for here. But at least the commit
fixes the build breakage which is quite annoying IMHO.