[FFmpeg-devel] [PATCH] Move av_open_input_file probe loop to its own method

[Micah F. Galizia]

On 10-03-05 06:44 AM, Michael Niedermayer wrote:
> On Thu, Mar 04, 2010 at 10:23:57PM -0500, Micah F. Galizia wrote:

[...]

>
> previous_size + error code<  0 doesnt look good

Fixed.

> [...]
>> Index: libavformat/avformat.h
>> ===================================================================
>> --- libavformat/avformat.h	(revision 22211)
>> +++ libavformat/avformat.h	(working copy)
>> @@ -872,7 +872,23 @@
>>    */
>>   AVInputFormat *av_probe_input_format(AVProbeData *pd, int is_opened);
>>
>> +
>>   /**
>> + * Probe a Bytestream to determine the input format.
>> + *
>> + * @param pb The bytestream to probe. It may be closed and opened again.
>> + * @param fmt The input format is put here.
>> + * @param filename The filename of the stream.
>> + * @param logctx The log context
>> + * @param offset The offset within the bytestream to probe from.
>> + * @param max_probe_size The maximum probe buffer size.
>> + * @return 0 if OK, AVERROR_xxx otherwise
>> + */
>> +int av_probe_input_buffer(ByteIOContext **pb, AVInputFormat **fmt,
>
> do we need this as public function?
> if not it should have a ff_ prefix and be in internal.h

Fixed.

-- 
Micah F. Galizia
micahgalizia at gmail.com

"The mark of an immature man is that he wants to die nobly for a cause, 
while the mark of the mature man is that he wants to live humbly for 
one."   --W. Stekel
-------------- next part --------------
A non-text attachment was scrubbed...
Name: probe_buffer2.diff
Type: text/x-diff
Size: 5376 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100306/ec77b7c2/attachment.diff>