[FFmpeg-devel] [RFC] libavformat: URL reassembly with IPv6 addresses

[Martin Storsjö]

On Fri, 5 Mar 2010, Ronald S. Bultje wrote:

> On Fri, Mar 5, 2010 at 10:27 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > On Fri, Mar 05, 2010 at 09:38:10AM -0500, Ronald S. Bultje wrote:
> >> On Fri, Mar 5, 2010 at 6:13 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> >> > On Thu, Mar 04, 2010 at 10:05:24AM -0500, Ronald S. Bultje wrote:
> >> >> Caller should call ff_network_init() before calling this (preferably
> >> >> in its _init() function). Caller should also call ff_network_close()
> >> >> once the last call is done (preferably in its close() function).
> >> >> Mention that in the doxy.
> >> >
> >> > that should be in url_open_protocol() then
> >>
> >> then the url_*() code would have to know whether we're a network protocol?
> >
> > it could assume every one is
> 
> Actually I was thinking of a CAP_* flag field in the URLProtocol
> declaration for this. But that's API breakage. Why don't we add it
> under a proper #if version <=> bla and if smaller, always
> ff_network_init()?
> 
> Or too much code, just add the damn thing?

Applied ff_network_init in url_open_protocol, OK'd by Ronald on IRC. The 
performance hit of needlessly initializing the network system while 
opening non-network protocols is negligible. Also applied the earlier OK'd 
parts regarding ff_url_join.

// Martin