[FFmpeg-devel] [PATCH] SHOUTcast HTTP Support

[Micah F. Galizia]

On 10-03-04 06:55 PM, Ronald S. Bultje wrote:
> Hi,
>
> On Thu, Mar 4, 2010 at 6:44 PM, Micah F. Galizia<micahgalizia at gmail.com>  wrote:
>> Sorry, I didn't explain this clearly.
> [..]
>> A large buffer size makes things worse when icy metadata is interleaved in
>> the stream.  After 32KB, supposing that is our meta-data interval, we have
>> the metadata (song title, artist and url in plaintext) in the stream data,
>> and this keeps the probe score low even with large buffers.
>
> So why don't you strip this off as well in the second probe?

To recap, on Michael's recommendation, I'm putting the probe loop from 
utils.c in its own method so the shoutcast demuxer can use it too.  The 
shoutcast demuxer isn't actually doing the probing. Additionally, MP3 
(or any other non-shoutcast demuxer) shouldn't need to know about 
shoutcast, so it should not be doing the stripping. If this were to be 
done in the shoutcast demuxer, I would need to ensure shoutcast got the 
probe data before the mp3 deuxmer did so it could remove the metadata. 
Additionally, it would mean I would somehow have to pass the state along 
so the demuxer knows if its probing or stripping. And then there is the 
actual stripping that would need to occur.  All of this seems over 
complicated in my opinion.

Limiting the probe buffer size is much easier since we will just accept 
the stream as MP3 with a low score (25) after 32KB.

-- 
Micah F. Galizia
micahgalizia at gmail.com

"The mark of an immature man is that he wants to die nobly for a cause, 
while the mark of the mature man is that he wants to live humbly for 
one."   --W. Stekel