[FFmpeg-devel] [PATCH] Add AV_CONFIG_* for libav* libs to libavutil/avconfig.h

Måns Rullgård mans
Wed Mar 3 01:30:01 CET 2010


Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:

> On date Thursday 2010-02-25 00:54:57 +0100, Stefano Sabatini encoded:
>> On date Sunday 2010-02-21 18:41:32 +0000, M?ns Rullg?rd encoded:
>> > Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>> > 
>> > > On date Sunday 2010-02-21 15:46:37 +0100, Reimar D?ffinger encoded:
> [...]
>> > >> So to say it without the flaming:
>> > >> Please include avconfig.h and if it doesn't contain what you need
>> > >> change it to include it.
>> > >
>> > > Check attached.
>> > 
>> > Let me think about it for a minute.
>> 
>> The minute passed on... ;-)
>
> Mans-ping.
> -- 
> FFmpeg = Freak and Fierce Magic Powered Empowered God
>
> From 0abab5186d10f9bb48c1f8387a1e8403f658d1f5 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> Date: Wed, 3 Mar 2010 00:53:47 +0100
> Subject: [PATCH] Add AV_CONFIG_* symbols for libav* libs to libavutil/avconfig.h,
>  and make ffmpeg.c and ffplay.c include avconfig.h rather than config.h.
>
> config.h should be never directly included by an application, not even
> by an internal ff* tool.

Those files depend on many more configure-detected values, some of
which should definitely not go into any installed header.

If we insist on not including config.h in ff*.c for some obscure
purist reasons, we will have to make configure output yet another
header just for these.  I really don't see any advantage in doing
that.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list