[FFmpeg-devel] Patch to fix qtrle endian issue with rgb555 pixel format

Michael Niedermayer michaelni
Tue Mar 2 20:23:13 CET 2010


On Tue, Mar 02, 2010 at 08:59:51AM -0800, Mo DeJong wrote:
> Michael, It is not clear that what you suggest is the best thing to
> do. What of the command line argument? Should the user be expected to
> pass "-pix_fmt rgb555be" instead of "-pix_fmt rgb555" in a case where
> the file format is always written in big endian? Why should the user
> need to indicate the endian format as well as how the pixels are
> packed?

if the user indicates the wrong pixel format then it doesnt work,
rgb555 is native endian, if native is little endian than rgb555be is a
different format

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Its not that you shouldnt use gotos but rather that you should write
readable code and code with gotos often but not always is less readable
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100302/b4a29cfa/attachment.pgp>



More information about the ffmpeg-devel mailing list