[FFmpeg-devel] [PATCH] dynload for libfaac

[Reinhard Tartler]

On Mo, M??r 01, 2010 at 06:10:26 (CET), Gianluigi Tiesi wrote:

> Hi,
> since libfaac cannot be linked in ffmpeg, I've made a patch similar to faadbin,
> I've made the patch for windows, but I've converted to use ldl on unix
> It worked for me on linux, but please test.
>
> I think the code can be unified e.g. with libfaadbin and maybe move
> some of the code in avutil
>
> I've removed at all the previous way to use libfaac, since it's not redistributable
> I think it does not make much sense to have it.

why not keeping it, and adding runtime loading support with
--enable-libfaacbin, similar like it is implemented curently with
libfaadbin? As other have noted, there is no problem with compiling and
running it, but redistributing it causes headaches for distributions.

> Anyway the patch can be easily modified to pick symbols from a linked
> lib with some ifdefs

yes, I think that would be more appropriate for ffmpeg upstream.

in any case, I like that approach and would love to add something like
that to the ubuntu ffmpeg package.

-- 
Gruesse/greetings,
Reinhard Tartler, KeyID 945348A4