[FFmpeg-devel] [PATCH] strict-aliasing-safe aes.c

Måns Rullgård mans
Mon Jun 28 19:34:32 CEST 2010


Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:

> On Mon, Jun 28, 2010 at 05:42:18PM +0100, M?ns Rullg?rd wrote:
>> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> 
>> > On Mon, Jun 28, 2010 at 05:10:03PM +0100, M?ns Rullg?rd wrote:
>> >> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
>> >> 
>> >> > Hello, this uses AV_WN32A, AV_WN64A etc. macros.  The generated code
>> >> > is the same on x86_64 (assuming I did not mess up that test).
>> >> 
>> >> Does it also get rid of some warnings?
>> >
>> > Some clang warnings yes (but a lot remain), but I don't know about
>> > gcc (haven't tried).
>> 
>> With gcc it removes some warnings and adds others.
>
> Hm, attached variant of the addkey code has a lot less warnings for me...

Nice!  Almost all gone.  Now if we could just apply my indexing patch,
it would be close to clean.

-- 
M?ns Rullg?rd
mans at mansr.com



More information about the ffmpeg-devel mailing list