[FFmpeg-devel] Correct libvorbis.c behaviour with >2 channels

Martin Storsjö martin
Sun Jun 27 11:32:43 CEST 2010


On Sun, 27 Jun 2010, James Darnley wrote:

> On 27 June 2010 06:38, David Conrad <lessen42 at gmail.com> wrote:
> >
> >> +const uint8_t ff_vorbis_encoding_channel_layout_offsets[8][8] = {
> >> + ? ?{ 0, },
> >> + ? ?{ 0, 1, },
> >> + ? ?{ 0, 2, 1, },
> >> + ? ?{ 0, 1, 2, 3, },
> >> + ? ?{ 0, 2, 1, 3, 4, },
> >> + ? ?{ 0, 2, 1, 4, 5, 3, },
> >> + ? ?{ 0, 2, 1, 5, 6, 4, 3, },
> >> + ? ?{ 0, 2, 1, 6, 7, 4, 5, 3},
> >> +};
> >> +
> >
> > Leave out the trailing comma and add a space before the } for 8 channels.
> >
> > Patch OK with that fixed
> 
> Done.

Applied.

> Have a free cosmetics patch too.

David, ok with this one too, even if would make newer patches larger due 
to the removed trailing comma that has to be readded if more channels are 
supported?

// Martin



More information about the ffmpeg-devel mailing list