[FFmpeg-devel] [PATCH] aactab: Tablegenify ff_aac_pow2sf_tab.

[Alex Converse]

On Wed, Jun 23, 2010 at 1:18 PM, Reimar D?ffinger
<Reimar.Doeffinger at gmx.de> wrote:
> On Tue, Jun 22, 2010 at 10:00:55PM +0200, Michael Niedermayer wrote:
>> On Tue, Jun 22, 2010 at 03:41:33PM -0400, Alex Converse wrote:
>> > On Sun, Jun 20, 2010 at 8:31 PM, Alex Converse <alex.converse at gmail.com> wrote:
>> > > ---
>> > > ?libavcodec/Makefile ? ? ? ? ? ?| ? ?2 +-
>> > > ?libavcodec/aac_tablegen.c ? ? ?| ? 39 ++++++++++++
>> > > ?libavcodec/aac_tablegen.h ? ? ?| ? 42 +++++++++++++
>> > > ?libavcodec/aac_tablegen_decl.h | ? 34 +++++++++++
>> > > ?libavcodec/aacdec.c ? ? ? ? ? ?| ? ?6 +--
>> > > ?libavcodec/aacenc.c ? ? ? ? ? ?| ? ?6 +-
>> > > ?libavcodec/aactab.c ? ? ? ? ? ?| ?127 +---------------------------------------
>> > > ?libavcodec/aactab.h ? ? ? ? ? ?| ? ?7 +--
>> > > ?8 files changed, 121 insertions(+), 142 deletions(-)
>> > > ?create mode 100644 libavcodec/aac_tablegen.c
>> > > ?create mode 100644 libavcodec/aac_tablegen.h
>> > > ?create mode 100644 libavcodec/aac_tablegen_decl.h
>> > >
>> > >
>> >
>> > ping?
>>
>> reimar?
>
> Sorry, completely missed it.
> First, it is aactab.c that includes the tablegen stuff, so I think the
> dependency should be
> $(SUBDIR)aactab.o: $(SUBDIR)aac_tables.h
>

very true

> And I am not sure it makes sense to try to make it work, but my original
> idea for this case was to do something along these lines:
> Put the generating code and aac_tables.h (i.e. what you now have in
> aac_tablegen.h) include into aactab.c, and have only the definitions in
> aac_tablegen.h (i.e. what currently is in aac_tablegen_decl.h)
> Then make the aac_tablegen binary use aactab.c, with something like this:
> $(SUBDIR)aac_tablegen$(HOSTEXESUF): aactab.c
> (and some other trick to make CONFIG_HARDCODED_TABLES defined when aactab.c
> gets compiled for the host).
> If you commit it as-is I can try to find some time to make above work in
> a non-ugly way (if possible at all) if you don't feel like doing it.

I'm going to take you up on this offer.