[FFmpeg-devel] [PATCH 2/2] Add ID support for .oma/.aa3

[Aurelien Jacobs]

On Thu, Jun 17, 2010 at 01:20:33AM +0200, Maxim wrote:
> Aurelien Jacobs schrieb:
> > On Wed, Jun 16, 2010 at 02:25:45PM +0200, Maxim wrote:
> >   
> >> Maxim schrieb:
> >>     
> >>> Maxim schrieb:
> >>>   
> >>>       
> >>>> Michael Karcher schrieb:
> >>>>   
> >>>>     
> >>>>         
> >>>>> Am Sonntag, den 13.06.2010, 13:03 +0200 schrieb Reimar D?ffinger:
> >>>>>   
> >>>>>     
> >>>>>       
> >>>>>           
> >>>>>>>> Don't worry too much about that.
> >>>>>>>> Anyway, I at least see no more mistakes/issues...
> >>>>>>>>         
> >>>>>>>>           
> >>>>>>>>             
> >>>>>>>>                 
> >>>>>>> then theres no reason not to commit it and add yourself to MAINTAINERs
> >>>>>>>       
> >>>>>>>         
> >>>>>>>           
> >>>>>>>               
> >>>>>> I can, though I haven't looked much at it and the original authors
> >>>>>> (Maxim and Benjamin) are still around.
> >>>>>> I assume nobody wants to maintain it?
> >>>>>>     
> >>>>>>       
> >>>>>>         
> >>>>>>             
> >>>>> Maxim seems to be willing to maintain it, see
> >>>>> http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/2010-June/090262.html
> >>>>>   
> >>>>>     
> >>>>>       
> >>>>>           
> >>>> Yes, it's true. I'd gladly maintain that demuxer but haven't had enough
> >>>> time to peer into it.
> >>>> I have alot of .oma/.aa3 samples on my HD. Let me test the code tonight.
> >>>> If there is no issues we'll commit it tomorrow, ok?
> >>>>   
> >>>>     
> >>>>         
> >>> I just tried the patch in both x86 and my G5 PPC box. It works fine for
> >>> all samples on x86, but refuses to display any metadata on PPC. Neither
> >>> ffplay nor ffmpeg shows metadata. I run the code through the gdb and
> >>> made sure that the metadata was decoded correctly. Has someone any
> >>> suggestions why it doesn't shows anything?
> >>>   
> >>>       
> >> Ping to the maintainers of the metadata API: where should I start to
> >> look in order to fix the problem described above?
> >>     
> >
> > No idea what your problem could be...
> > Metadata API should work the same on any arch.
> > I just tried on PPC and got the same result than on x86:
> >   
> 
> Ok, which function is responsible for displaying the metadata? In the
> FFmpeg executable there is nothing looks like that...

libavformat/utils.c:dump_metadata() called by dump_format() and
dump_stream_format().

Aurel