[FFmpeg-devel] [PATCH] Add "unofficial" command line option

[Rodney Baker]

On Wed, 16 Jun 2010 07:36:10 Stefano Sabatini wrote:
> On date Wednesday 2010-06-16 01:42:46 +0930, Rodney Baker encoded:
> > This adds the "unofficial" command line option and leaves the current
> > "inofficial" with a change to the description to note that it is to be
> > deprecated.
> > 
> > There may be a cleaner way to do this - I am a rank beginner at this so I
> > don't know if this is the right way handle this or not. I'm happy for
> > someone to propose a better solution...
> 
> We use the
> #if LIBAVSTUFF_VERSION_MAJOR < NEXT
> ...
> #endif
> 
> construct when we want to deprecate something, this way we're sure
> that old stuff won't be kept around when we'll break compatibility
> (which happens *only* at major version bumps).
> 
> [...]
> 
> Regards.

You mean like the attached? I note that there is a similar block of code 
further up the options list. Is it OK to move these options up and use the 
same #if...#endif block or would you prefer to leave them where they are (as 
in the attached patch)?

BTW, this patch currently has the changes from the other proposed patches that 
Michael has not yet approved because they break API, so I will revert those 
changes for this patch if it is OK - just checking that this is what you 
meant.


-- 
===================================================
Rodney Baker VK5ZTV
rodney.baker at iinet.net.au
=================================================== 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lavc-options-c.diff-20100117-1
Type: text/x-patch
Size: 1474 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100616/79f25b5b/attachment.bin>