[FFmpeg-devel] [PATCH 2/2] Add ID support for .oma/.aa3

Reimar Döffinger Reimar.Doeffinger
Thu Jun 10 23:55:12 CEST 2010


On Tue, Jun 08, 2010 at 12:06:40AM +0200, Michael Karcher wrote:
> Am Montag, den 07.06.2010, 23:51 +0200 schrieb Reimar D?ffinger:
> > > +    if(ff_id3v2_match(buf, ID3v2_EA3_MAGIC)) {
> > > +        buf += ff_id3v2_tag_len(buf);
> > > +    }
> > > +
> > > +    if (!memcmp(buf, "EA3", 3) && !buf[4] && buf[5] == EA3_HEADER_SIZE)
> > Uh, no buffer size check?
> > And missing space after "if" and unnecessary {}
> 
> Oh, good point. I hope the attached patch fixes these issues.

This one is unchanged compared to before...



More information about the ffmpeg-devel mailing list