[FFmpeg-devel] [RFC] Export eval.h?

Stefano Sabatini stefano.sabatini-lala
Wed Jun 9 00:15:57 CEST 2010


On date Monday 2010-06-07 03:43:29 +0200, Michael Niedermayer encoded:
> On Sat, Jun 05, 2010 at 11:27:00PM +0200, Stefano Sabatini wrote:
[...]
> >  cmdutils.c                   |    8 ++++++--
> >  doc/fftools-common-opts.texi |    5 +++++
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> > 3396c5dc56bd6ce97edb26326316474ab72d431c  0001-Make-all-the-numeric-options-accepts-in-input-an-exp.patch
> > >From 883c306338ce2f1b37ca04db4ec55f41345989fd Mon Sep 17 00:00:00 2001
> > From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> > Date: Sat, 5 Jun 2010 23:22:38 +0200
> > Subject: [PATCH] Make all the numeric options accepts in input an expression which is
> >  evaluated through the eval API.
> > 
> > Fix roundup issue #551.
> 
> ok

Now I see this introduces an usability regression, for example using
-fs 4gi rather than -fs 4Gi the value obtained is 4, and the final
"gi" is simply discarded. This because currently the eval API doesn't
allow to set the tail to the parsed expression (which maybe should be
addressed?).

Anyway my fix is to simply use av_strtod().

Regards.
-- 
FFmpeg = Free and Fascinating Most Power Extroverse God



More information about the ffmpeg-devel mailing list