[FFmpeg-devel] [PATCH 7/7] Add check in av_write_header() which validates the rawvideo codec tag.

Stefano Sabatini stefano.sabatini-lala
Sun Jun 6 02:02:21 CEST 2010


On date Sunday 2010-06-06 01:40:55 +0200, Michael Niedermayer encoded:
> On Sat, Jun 05, 2010 at 09:46:07PM +0200, Stefano Sabatini wrote:
> [...]
> >  const AVCodecTag ff_nut_video_tags[] = {
> > +    { CODEC_ID_RAWVIDEO, 0                         },
> 
> rejected
> 
> i keep saying the same thing and you keep doing the exact opposit.
> i fixed it and ill add some reg test, 

It didn't fix neither NUT nor AVI. Please try this:

ffmpeg -t 10 -i IN.flv -pix_fmt rgb444 -vcodec rawvideo -y OUT-rgb444.nut

(or with OUT-rgb444.avi)

and then try to play the output file with ffplay.

What I'd expect is the NUT encoder to fail gracefully. Note that what
I implemented is consistent with what is done in ff_bmp_codec_tags, so
it looked to me just The Right Fix (TM).

> this will simplify it to "dont break the reg test"

Regards.
-- 
FFmpeg = Friendly & Funny Mega Portentous Enhancing Guru



More information about the ffmpeg-devel mailing list