[FFmpeg-devel] [PATCH] id3v2: always skip padding

[Alexander Kojevnikov]

On 28 July 2010 01:14, Michael Niedermayer <michaelni at gmx.at> wrote:
> no
> look at the code:
>
> ? ? ? ?len -= taghdrlen + tlen;
> ...
> ? ? ? ?next = url_ftell(s->pb) + tlen;
>
> ? ? ? ?if (tag[0] == 'T')
> ? ? ? ? ? ?read_ttag(s, tlen, tag);
> ? ? ? ?else if (!tag[0]) {
> ? ? ? ? ? ?if (tag[1])
> ? ? ? ? ? ? ? ?av_log(s, AV_LOG_WARNING, "invalid frame id, assuming padding");
> ? ? ? ? ? ?url_fskip(s->pb, len);
> ? ? ? ? ? ?break;
> ? ? ? ?}
> ? ? ? ?/* Skip to end of tag */
> ? ? ? ?url_fseek(s->pb, next, SEEK_SET);
>
>
> tlen is subtracted from len but its not read or skiped in any way in the
> break case above

I see now, attached patch fixes this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-id3v2-always-skip-padding.patch
Type: text/x-patch
Size: 1095 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100728/908be6ac/attachment.bin>