[FFmpeg-devel] [PATCH] Move av_parse_frame_size() and av_parse_frame_rate() from libavcodec to libavcore

Stefano Sabatini stefano.sabatini-lala
Sun Jul 25 14:14:36 CEST 2010


On date Sunday 2010-07-25 12:57:16 +0200, Michael Niedermayer encoded:
> On Sun, Jul 25, 2010 at 12:51:16PM +0200, Stefano Sabatini wrote:
[...]
> > I don't see why this is necessary, the function was already public,
> > doing it after or before makes no difference (apart from wasting my
> > time, which I'd like to avoid).
> 
> I wasnt conciously aware that this function was public and used, if so you
> will have to deal with the linker-versioning-workaround machinery.
> reinhard should be able to explain how to do that without triggering
> assert(0) in the linker

What about exporting the function as an av_parse_video_frame_size2()
symbol in lavcore, and making lavc:av_parse_video_frame_size() depend
on that?

That would have a performance hit, given the function is not
performance-critical at all that shouldn't be a problem though.

Regards.
-- 
FFmpeg = Frightening Free Multipurpose Programmable Erudite Gargoyle



More information about the ffmpeg-devel mailing list