[FFmpeg-devel] [PATCH] id3v2 unsynchronisation support

[Alexander Kojevnikov]

On 24 July 2010 22:09, Reimar D?ffinger <Reimar.Doeffinger at gmx.de> wrote:
> On Sat, Jul 24, 2010 at 09:58:10PM +1000, Alexander Kojevnikov wrote:
>> On a side note, I'm seeing bogus "value computed is not used" warnings
>> with this code (gcc 4.5.0), should something be done about them?
>
> They aren't bogus, it must be (*len)--, not *len--;
> Or *len -= 1;
> Or whatever other method.

Fixed.

>> + ? ?int byte;
>
> This can now be moved into the blocks where it is used.

Done.

>> - ? ? ? ?while (taglen-- && q - dst < dstlen - 7) {
>> + ? ? ? ?byte = 0;
>
> Since there is no need to initialize it to 0.

Fixed in both places.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-aviobuf-add-peek_byte.patch
Type: text/x-patch
Size: 1448 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100725/5ca39b8a/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-id3v2-unsynchronisation-support.patch
Type: text/x-patch
Size: 5160 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100725/5ca39b8a/attachment-0001.bin>