[FFmpeg-devel] [PATCH 3/3] Add missing comma, fix rgb2yuv_table[SWS_CS_SMPTE240M] coefficients.

[Stefano Sabatini]

On date Friday 2010-07-23 19:21:05 +0200, Stefano Sabatini encoded:
> On date Friday 2010-07-23 19:03:50 +0200, Vitor Sessak encoded:
> > On 07/23/2010 06:54 PM, Stefano Sabatini wrote:
> > >From: Stefano Sabatini<stefano at iosto.(none)>
> > >
> > >---
> > >  swscale.c |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > >
> > >diff --git a/swscale.c b/swscale.c
> > >index e891e57..6cd4fc1 100644
> > >--- a/swscale.c
> > >+++ b/swscale.c
> > >@@ -104,7 +104,7 @@ static const double rgb2yuv_table[8][9]={
> > >      {0.59  , 0.11  , 0.30  , -0.331, 0.5, -0.169, -0.421, -0.079, 0.5}, //FCC
> > >      {0.587 , 0.114 , 0.299 , -0.331, 0.5, -0.169, -0.419, -0.081, 0.5}, //DEFAULT / ITU601 / ITU624 / SMPTE 170M
> > >      {0.587 , 0.114 , 0.299 , -0.331, 0.5, -0.169, -0.419, -0.081, 0.5}, //DEFAULT / ITU601 / ITU624 / SMPTE 170M
> > >-    {0.701 , 0.087 , 0.212 , -0.384, 0.5  -0.116, -0.445, -0.055, 0.5}, //SMPTE 240M
> > >+    {0.701 , 0.087 , 0.212 , -0.384, 0.5, -0.116, -0.445, -0.055, 0.5}, //SMPTE 240M
> > >  };
> > 
> > Is there any code using this table?
> 
> Well there is sws_getCoefficients(), 

No, I was confused, indeed sws_getCoefficients() is returning the
coefficients in yuv2rgb.c:ff_yuv2rgb_coeffs.

> but no in lsws there is no code using the rgb2yuv table.

So this is a good pretest to ask: what's the role of the
rgb2yuv_table?, could it be simply discarded (for example maybe it
can be computed from the ff_yuv2rgb coeffs)?

I'm still figuring out what ff_yuv2rgb_c_init_tables() is exactly
doing...

Regards.
-- 
FFmpeg = Frightening & Furious Minimal Prodigious Ecumenical Genius