[FFmpeg-devel] [PATCH] Generalize pixel format enum fields to int formats

Stefano Sabatini stefano.sabatini-lala
Wed Jul 21 20:19:19 CEST 2010


On date Wednesday 2010-07-21 10:27:18 -0700, S.N. Hemanth Meenakshisundaram encoded:
> > On Wed, Jul 21, 2010 at 02:38:28AM -0700, S.N. Hemanth Meenakshisundaram
> > wrote:
> >> Hi,
> >>
> >> Patch updated with the compact notation for intializing num_formats in
> >> avfilter_all_formats and type in avfilter_default_query_formats. This
> >> works with make lavfitest and make test. However the next patch in the
> >> series "lavfi audio framework" fails those tests. More details on that
> >> in that thread.
> >>
> >> ---
> 
> 
> libavfilter/avfilter.c      |    6 ++++--
> libavfilter/avfilter.h      |   22 ++++++++++++----------
> libavfilter/avfiltergraph.c |    4 ++--
> libavfilter/defaults.c      |    6 +++++-
> libavfilter/formats.c       |   32 +++++++++++++++++---------------
> libavfilter/vf_scale.c      |    4 ++--
> 6 files changed, 41 insertions(+), 32 deletions(-)
> 
> 
> Assert added and trailing whitespace removed.
> 
> Where should I add the API changes entry?

doc/APIchanges

> Also for the conditional in formats.c, I could replace it with
> positive conditions but there would then be more than 2
> conditions. is that ok?

Yes please (I find it a little more readable).

Regards.
-- 
FFmpeg = Formidable & Fancy MultiPurpose EnGine



More information about the ffmpeg-devel mailing list