[FFmpeg-devel] [PATCH] Log a warning when receiving HTTP error codes

[Luca Barbato]

On 07/16/2010 04:05 PM, Ronald S. Bultje wrote:
> Hi,
> 
> On Fri, Jul 16, 2010 at 9:59 AM, Martin Storsj? <martin at martin.st> wrote:
>> On Fri, 16 Jul 2010, Ronald S. Bultje wrote:
>>> On Fri, Jul 16, 2010 at 7:52 AM, Martin Storsj? <martin at martin.st> wrote:
>>>> $subj - this simplifies debugging quite a bit, and improves usability in
>>>> general, too.
>>>
>>> Great idea, I've always debugged using such code and then never
>>> committed. Bad me.
>>>
>>> As for that patch, I wonder if you could insert a new variable for the
>>> endptr argument to strtol() just above this code, then skip_spaces()
>>> or strspn() and that way get a pointer to the actual text string, and
>>> debug that also. That would assist even more in "usability" (well, for
>>> developers I guess).
>>
>> Good idea - attached version does this, too.
> [..]
>> +            while (isspace(*end))
>> +                end++;
> 
> end += strspn(end, SPACE_CHARS);, OK otherwise.

Want me to update the similar code in rtsp to show the reason as well?

lu

-- 

Luca Barbato
Gentoo/linux
http://dev.gentoo.org/~lu_zero