[FFmpeg-devel] [RFC] libavfilter audio framework - split patches

S.N. Hemanth Meenakshisundaram smeenaks
Tue Jul 13 11:35:18 CEST 2010


Michael Niedermayer wrote:
> On Sun, Jul 11, 2010 at 07:07:19AM -0700, S.N. Hemanth Meenakshisundaram wrote:
>   
>> S.N. Hemanth Meenakshisundaram wrote:
>>     
>>> I am sending out the working lavfi audio patches in the order Stefano 
>>> requested for easy committing.
>>>       
>> avfiltergraph.c changes. Only some cosmetic changes on this one.
>>     
>> -    /* ask all the sub-filters for their supported colorspaces */
>> -    for(i = 0; i < graph->filter_count; i ++) {
>> -        if(graph->filters[i]->filter->query_formats)
>> +    /* ask all the sub-filters for their supported colorspaces/sample formats */
>> +    for (i = 0; i < graph->filter_count; i ++)
>> +        if (graph->filters[i]->filter->query_formats)
>> [...]
>> -    link->format = link->in_formats->formats[0];
>> +
>> +    if      (link->type == AVMEDIA_TYPE_VIDEO) link->format = link->in_formats->formats[0];
>> +    else if (link->type == AVMEDIA_TYPE_AUDIO) link->aformat = link->in_formats->aformats[0];
>>  
>>     
>
> the first hunk looks cosmetic (and i think the {} should stay)
> the second hunk does not look cosmetic
>   

Added back braces and removed the format/aformat duplication.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: avfigraph_changes.diff
Type: text/x-patch
Size: 1309 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100713/06c769e1/attachment.bin>



More information about the ffmpeg-devel mailing list